-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace references to serial interval with generation interval #116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes!
I would prefer generation_interval
to gen_interval
. Do you think it's too much to type?
Or as a compromise we could call it generation_time
(only 3 characters more than gen_interval
...) which would have the benefit of being the same as in EpiNow2.
I'm a big fun of {EpiNow2}, so I'll go with this. I think there is a similar notion in {epiparameter}, so +1. Will make the change. |
6e892a5
to
3fe6637
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
==========================================
+ Coverage 98.06% 98.64% +0.57%
==========================================
Files 8 8
Lines 518 518
==========================================
+ Hits 508 511 +3
+ Misses 10 7 -3 ☔ View full report in Codecov by Sentry. |
cfec50b
to
3fe6637
Compare
3fe6637
to
bf4a751
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looking good - we're now using both generation "time" and "interval". Perhaps that's fine as they're used interchangeably in the literature but I was wondering if it would be worth doing a search/replace "generation interval" -> "generation time" everywhere and clarify in just one point that they're the same (I made a suggestion where).
This PR closes #109 by:
serials_dist
argument togen_interval