fix(protocol): set initial owner in the init() function without acceptOwnership
#16071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaki2004
reviewed
Feb 26, 2024
dantaik
changed the title
dantaik
changed the title
acceptOwnership
davidtaikocha
approved these changes
Feb 26, 2024
adaki2004
approved these changes
Feb 26, 2024
This was referenced Feb 26, 2024
This was referenced Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR looks extensive, but it's mostly grammatical changes.
Now, all contracts are Ownable2StepUpgradeable for better security. But when they are initialized (using
init(...)), the initial owner doesn't have to callacceptOwnershipto become the current owner (all new owners must do that though). These changes will make David C's deployment much easier.